Add length validation to text input #3193
Conversation
bpedersen2
force-pushed
the
field_limits
branch
3 times, most recently
from
2e4bca3
to
fcd1b69
Compare
| </label> | ||
| <input type="text" name="validpattern" | ||
| ng-model="formData.validPattern" | ||
| > |
There was a problem hiding this comment.
should go in the previous line (also two more times above)
| <input type="text" name="validpattern" | ||
| ng-model="formData.validPattern" | ||
| > | ||
| <i class="info-helper" title="{{ 'Validation pattern for input , see https://www.w3schools.com/jsref/jsref_obj_regexp.asp }}' | i18n }}"></i> |
There was a problem hiding this comment.
Even though w3schools isn't as awful as they used to be (but the still sell those phony "html certificates"), I don't want a link to them in Indico ;) (also, there shouldn't be a space before the ,).
Maybe letting users specify regex patterns here is a bit overkill anyway...
There was a problem hiding this comment.
removed the link.
Using pattern validation can e.g. be used if you need special input from the registrants (e.g only uppercaser, no spaces, etc.)
| <input type="number" name="maxlength" | ||
| ng-model="formData.maxLength" | ||
| > | ||
| <i class="info-helper" title="{{ 'Maximimum allowed length' | i18n }}"></i> |
bpedersen2
force-pushed
the
field_limits
branch
from
fcd1b69
to
c85d19a
Compare
| {{ 'Validation pattern' | i18n }} | ||
| </label> | ||
| <input type="text" name="validpattern" ng-model="formData.validPattern"> | ||
| <i class="info-helper" title="{{ 'Validation pattern(a javascript regualr expression) }}' | i18n }}"></i> |
There was a problem hiding this comment.
missing space before ( and a typo (regualr).
Anyway, I still don't like the idea of having the pattern option. Yes, it is powerful, but eventually we want server-side validation for this stuff and except when restricting yourself to a common subset of the regex features of HTML5/JS and Python, that won't be guaranteed to work on both sides...
Also, having user-provided regexps run on the server may be risky - usually there are some ways to write regular expressions that result in horrible performance.
There was a problem hiding this comment.
I splitted this part out, as regexp validation is not too important for now.
| ng-class="{ | ||
| hasError: validationStarted && nestedForm.$invalid | ||
| }"/> | ||
|
|
||
| <span ng-show="validationStarted && nestedForm.$invalid && nestedForm.$error.minlength" class="error-message-tag"> |
There was a problem hiding this comment.
double space before class (same below)
bpedersen2
force-pushed
the
field_limits
branch
from
c85d19a
to
5ad5e30
Compare
ThiefMaster
changed the title
bpedersen2
force-pushed
the
field_limits
branch
3 times, most recently
from
6e5cc39
to
c213091
Compare
|
Ping... |
ThiefMaster
force-pushed
the
field_limits
branch
from
9ed5f8a
to
8e09652
Compare
This change allows to enforce minimum and maximum length limit for registration form text input fields.
ThiefMaster
force-pushed
the
field_limits
branch
from
8e09652
to
972375e
Compare
|
Don't worry, we didn't forget about it - just busy with other things ;) It's cleaned up (typos etc.) and merged now. Thanks for the PR! |
This change allows to enforce minimum and maximum length
limit and/or pattern restrictions for regform text input fields.